fix: keep shared Chrome alive across agent exits - #16
Merged
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EPERMandEBUSYrecovery-file replacements automaticallyASK_PRO_AGENT_IDremains only for explicit profile isolationWhy
The shared browser lease correctly left Chrome running for a peer, but
chrome-launcherspawned Chrome as a non-detached Windows child. When the first controller exited, its host process tree could still terminate Chrome under the second agent. Transient Windows rename failures could then prevent saved browser metadata from making that interrupted answer recoverable.Impact
Agents still run
ask-pro, attach context, and submit the prompt. There are no new flags, environment variables, settings, profiles, or services.Checks
pnpm run buildpnpm run lintpnpm test(287 passed)pnpm run format:checkpnpm pack --dry-runrvw_002abc85(clean)